Skip to content

Fixed an ifndef error #9262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2018
Merged

Fixed an ifndef error #9262

merged 1 commit into from
May 15, 2018

Conversation

mburke5678
Copy link
Contributor

@mburke5678 mburke5678 commented May 15, 2018

I was alerted to this error from a translation question (the pull-through feature phrase was repeated in Origin).
I made this change to the ifndef statement to match how similar ifdef statements are formatted. It works in an asciibinder build preview.

@openshift/team-documentation PTAL to make sure this command is now correct.

ps. I noticed after-the-fact that the error was fixed in 3.9 and 3.10. #8038

@mburke5678 mburke5678 requested a review from adellape May 15, 2018 15:11
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 15, 2018
@mburke5678 mburke5678 added the okd-only Content that is only relevant to upstream OKD docs. label May 15, 2018
@mburke5678 mburke5678 added this to the Next Release milestone May 15, 2018
@kalexand-rh
Copy link
Contributor

It looks right to me. I'm glad it works locally!

@mburke5678 mburke5678 closed this May 15, 2018
@mburke5678 mburke5678 reopened this May 15, 2018
@mburke5678 mburke5678 merged commit 97ae21d into openshift:master May 15, 2018
@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-3.10

@mburke5678 mburke5678 deleted the ifndef-error branch May 15, 2018 17:14
@openshift-cherrypick-robot

@mburke5678: new pull request could not be created: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:enterprise-3.10 and openshift-cherrypick-robot:cherry-pick-9262-to-enterprise-3.10"}],"documentation_url":"https://developer.github.com/v3/pulls/#create-a-pull-request"}

In response to this:

/cherrypick enterprise-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-3.9

@openshift-cherrypick-robot

@mburke5678: new pull request could not be created: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:enterprise-3.9 and openshift-cherrypick-robot:cherry-pick-9262-to-enterprise-3.9"}],"documentation_url":"https://developer.github.com/v3/pulls/#create-a-pull-request"}

In response to this:

/cherrypick enterprise-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-3.7

@openshift-cherrypick-robot

@mburke5678: new pull request created: #9265

In response to this:

/cherrypick enterprise-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-3.6

@openshift-cherrypick-robot

@mburke5678: new pull request created: #9267

In response to this:

/cherrypick enterprise-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-3.5

@openshift-cherrypick-robot

@mburke5678: new pull request created: #9268

In response to this:

/cherrypick enterprise-3.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-3.4

@openshift-cherrypick-robot

@mburke5678: new pull request created: #9269

In response to this:

/cherrypick enterprise-3.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants